fix(reclaim): verify_target tiers typed holds (composition bug from #21+#22) #23
+38
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holds) Merging slice-3 (#21, verify_target) and typed holds (#22) composed a latent bug: #22 makes load_holds return typed dict entries, but verify_target still did inline string matching (h in source_folder), which raises TypeError on a dict hold — i.e. verify_target would crash on any routed target the moment a reclaim_holds.json is used. Legacy .txt (string) holds were unaffected, so the merged suite stayed green and it went unseen. Route verify_target through the same hold_entry_for + classify_hold helpers verify() uses, so routed targets get the full business/promote-pending/superseded tiering (HOLD / AWAITING- APPROVAL) instead of a flat crash-prone string match. Tests: verify_target under a business dict hold -> HOLD, promote-pending no-receipt -> HOLD, promote-pending valid-receipt -> AWAITING-APPROVAL. Suite 235 -> 238. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
verify_targettiers typed holds (composition bug from merging #21 + #22)Merging slice-3 (#21,
verify_target) and typed holds (#22) composed a latent bug:#22 makes
load_holdsreturn typed dict entries, butverify_targetstill did inlinestring matching (
h in source_folder), which raises TypeError on a dict hold. Soverify_targetwould crash on any routed target the moment areclaim_holds.jsonis used.Legacy
.txt(string) holds are unaffected, which is why the merged 235-test suite stayedgreen and it went unseen.
Fix: route
verify_targetthrough the samehold_entry_for+classify_holdhelpersverify()uses, so routed targets get the full business / promote-pending / supersededtiering (
HOLD/AWAITING-APPROVAL) instead of a flat, crash-prone string match.Tests (+3):
verify_targetunder a business dict hold → HOLD; promote-pending no-receipt →HOLD; promote-pending valid-receipt → AWAITING-APPROVAL. Suite 235 → 238.
Base
main, not stacked. This is the "apply tiering to verify_target once #21 lands"follow-up I flagged — closing it now so
mainis correct before anyone deploys JSON holds.🤖 Generated with Claude Code